Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow partition key to be passed as a parameter #89

Open
adrianlungu opened this issue Oct 18, 2024 · 0 comments
Open

Allow partition key to be passed as a parameter #89

adrianlungu opened this issue Oct 18, 2024 · 0 comments
Assignees

Comments

@adrianlungu
Copy link

Hello,

Looking at the FixedWindowDynamoDB (and probably the others as well), it would be great if the partitionKey could be passed as a parameter in Increment instead of as part of the struct.

In highly concurrent scenarios, where multiple keys would need to be handled potentially at the same time, being able to re-use the same FixedWindow per table, and not per key, to increase multiple keys via the function call would be ideal.

I didn't get a chance to look at the extent of how such a change would impact the library as a whole, for FixedWindowDynamoDB it does not look like a big change, although it would be a breaking change.

@mennanov mennanov self-assigned this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants