Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert 3.3.11+ changes #239

Closed
fritzmg opened this issue Oct 13, 2017 · 5 comments
Closed

revert 3.3.11+ changes #239

fritzmg opened this issue Oct 13, 2017 · 5 comments

Comments

@fritzmg
Copy link
Contributor

fritzmg commented Oct 13, 2017

Releases 3.3.11 and 3.3.12 were broken due to

  • missing minified JavaScripts
  • newly added dependency to the dc-general, without adding the requirement to the composer.json

and thus they are unusable.

However, even tough 3.3.13 was released with the added dc-general dependency, most users will only get 3.3.12 and not higher, since there is no stable release for dc-general 2.x. This will leave many users with either broken multicolumwizard fields or even completely broken installations once they update their packages.

@discordier
Copy link
Collaborator

The dependency should have never been added.
It should become a weak dependency and therefore be added to the suggests section instead.

The event listener must of course get updated along.

@zonky2
Copy link
Collaborator

zonky2 commented Oct 15, 2017

@stefanheimes

This should solve a problem with the fileTree Widget or the pageTree widget.
747bdc7#commitcomment-24806245

... welches Problem sollte denn gelöst werden?

@fritzmg
Copy link
Contributor Author

fritzmg commented Oct 15, 2017

@zonky2 #215

@Toflar
Copy link
Contributor

Toflar commented Oct 17, 2017

Sorry but could anybody fix the releases soon? The MCW is used in so many extensions out there, please be careful when you release a new version! Right now, the minified JS is broken and I have to pin the dependency to 3.3.10 in all projects. And why the fuck is dc-general a dependency?

@discordier
Copy link
Collaborator

See #240

davidmaack added a commit that referenced this issue Oct 24, 2017
Fix #239 - make dc-general optional again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants