Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUSTSEC-2020-0071: Potential segfault in the time crate #40

Closed
github-actions bot opened this issue Jan 16, 2022 · 2 comments
Closed

RUSTSEC-2020-0071: Potential segfault in the time crate #40

github-actions bot opened this issue Jan 16, 2022 · 2 comments
Labels
cause::direct dependency This issue is caused/concerns a direct dependency of GitArena platform::linux type::security

Comments

@github-actions
Copy link

Potential segfault in the time crate

Details
Package time
Version 0.1.44
URL time-rs/time#293
Date 2020-11-18
Patched versions >=0.2.23
Unaffected versions =0.2.0,=0.2.1,=0.2.2,=0.2.3,=0.2.4,=0.2.5,=0.2.6

Impact

Unix-like operating systems may segfault due to dereferencing a dangling pointer in specific circumstances. This requires an environment variable to be set in a different thread than the affected functions. This may occur without the user's knowledge, notably in a third-party library.

The affected functions from time 0.2.7 through 0.2.22 are:

  • time::UtcOffset::local_offset_at
  • time::UtcOffset::try_local_offset_at
  • time::UtcOffset::current_local_offset
  • time::UtcOffset::try_current_local_offset
  • time::OffsetDateTime::now_local
  • time::OffsetDateTime::try_now_local

The affected functions in time 0.1 (all versions) are:

  • at
  • at_utc
  • now

Non-Unix targets (including Windows and wasm) are unaffected.

Patches

Pending a proper fix, the internal method that determines the local offset has been modified to always return None on the affected operating systems. This has the effect of returning an Err on the try_* methods and UTC on the non-try_* methods.

Users and library authors with time in their dependency tree should perform cargo update, which will pull in the updated, unaffected code.

Users of time 0.1 do not have a patch and should upgrade to an unaffected version: time 0.2.23 or greater or the 0.3 series.

Workarounds

No workarounds are known.

References

time-rs/time#293

See advisory page for additional details.

@mellowagain
Copy link
Owner

GitArena contains three different versions of time:

  • time 0.1.43 (affected)
  • time 0.2.27 (unaffected)
  • time 0.3.3 (unaffected)

Dependency graph for time 0.1.43:

  • chrono
    • time 0.1.43 (affected crate)
  • lettre 0.10.0-alpha.2
    • hyperx 1.1.0
      • time 0.1.43 (affected crate)
  • zip 0.5.13
    • time 0.1.43 (affected crate)

@mellowagain mellowagain added cause::direct dependency This issue is caused/concerns a direct dependency of GitArena cause::indirect dependency This issue is caused/concerns a indirect dependency of GitArena (dependency of a dependency) and removed status::investigating cause::indirect dependency This issue is caused/concerns a indirect dependency of GitArena (dependency of a dependency) labels Jan 16, 2022
@mellowagain
Copy link
Owner

Fixed by upgrading to time 0.3.5 in c8c53a7. chrono still depends on an older version which does not have the fix applied. Tracking that security issue in #35.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cause::direct dependency This issue is caused/concerns a direct dependency of GitArena platform::linux type::security
Projects
None yet
Development

No branches or pull requests

1 participant