Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make red outlines around okurigana in kanji entries optional #1120

Closed
Konstantin-Glukhov opened this issue Jul 6, 2022 · 4 comments · Fixed by #1521
Closed

Make red outlines around okurigana in kanji entries optional #1120

Konstantin-Glukhov opened this issue Jul 6, 2022 · 4 comments · Fixed by #1521
Labels
enhancement good first issue released

Comments

@Konstantin-Glukhov
Copy link

The following snapshot shows the red outlines/boxes around okurigana in kanji definition. Could you make it optional, or disable. These boxes are distracting.

image
@melink14
Copy link
Owner

melink14 commented Jul 6, 2022

Honestly, this behavior was inherited from the version that this forked and I agree that it's probably not needed as long as the color matches. Should be easy to remove from the CSS (maybe a small HTML chagne too)

I would probably play with it in Dev Tools and then make the change.

@melink14
Copy link
Owner

melink14 commented Jul 6, 2022

@all-contributors Add @Konstantin-Glukhov for ideas.

@allcontributors allcontributors bot mentioned this issue Jul 6, 2022
Merged
@allcontributors
Copy link
Contributor

@melink14

I've put up a pull request to add @Konstantin-Glukhov! 🎉

mergify bot pushed a commit that referenced this issue Jul 6, 2022
@allcontributors
docs: Add Konstantin-Glukhov as a contributor for ideas (#1121)
cdb94aa 
Add @Konstantin-Glukhov as a contributor for ideas.

This was requested by melink14 [in this comment](#1120 (comment))
@tora-pan tora-pan mentioned this issue Apr 16, 2023
Merged
melink14 added a commit that referenced this issue Dec 22, 2024
@tora-pan @melink14 @github-actions
feat(kanji): Add option to remove okurigana highlighting (#1521)
f6afba8 
Gives the user the ability to toggle (on/off) the highlighting of the okurigana via the extension options page.

![options](https://user-images.githubusercontent.com/81494248/232315262-bd3d30e7-3dcb-4a91-9b53-107b66b480da.png)
![noHighlightV2](https://user-images.githubusercontent.com/81494248/232315161-3005e650-e29a-4e21-8695-667661e088d6.png)

Fixes  #1120 


---------

Co-authored-by: Erek Speed <[email protected]>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
melink14 pushed a commit that referenced this issue Dec 23, 2024
@semantic-release-bot
chore(release): 3.1.0
07728f1 
## [3.1.0](v3.0.13...v3.1.0) (2024-12-23)

### Features

* **kanji:** Add option to remove okurigana highlighting ([#1521](#1521)) ([f6afba8](f6afba8)), closes [#1120](#1120)

### Bug Fixes

* Add logic to return early if hover returns empty string ([#1446](#1446)) ([a5dcdc4](a5dcdc4)), closes [#1417](#1417)
* **dict:** Update dictionaries to latest versions ([#2349](#2349)) ([cd16362](cd16362))
@melink14
Copy link
Owner

🎉 This issue has been resolved in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(kanji): Add option to remove okurigana highlighting tora-pan/rikaikun
2 participants
@melink14 @Konstantin-Glukhov