Use Finding class in Polyspace checker; Update test code quality reports

Author: JokeWaumans

src/mlx/warnings/polyspace_checker.py

@@ -4,6 +4,7 @@
 import os
 from string import Template
 
+from .code_quality import Finding
 from .exceptions import WarningsConfigError
 from .warnings_checker import WarningsChecker
 
@@ -215,44 +216,29 @@ def add_code_quality_finding(self, row):
         Args:
             row (dict): The row of the warning with the corresponding colomn names
         '''
-        finding = {
-            "severity": "major",
-            "location": {
-                "path": self.cq_default_path,
-                "positions": {
-                    "begin": {
-                        "line": 1,
-                        "column": 1
-                    }
-                }
-            }
-        }
-
         try:
             description = self.cq_description_template.substitute(os.environ, **row)
         except KeyError as err:
             raise WarningsConfigError(f"Failed to find environment variable from configuration value "
                                       f"'cq_description_template': {err}") from err
 
+        finding = Finding(description)
         # Attention to bug finder: items have color red for impact: high, medium and low.
         if row["information"].lower() in self.code_quality_severity.keys():
-            finding["severity"] = self.code_quality_severity[row["information"].lower()]
+            finding.severity = self.code_quality_severity[row["information"].lower()]
         elif row["color"].lower() in self.code_quality_severity.keys():
-            finding["severity"] = self.code_quality_severity[row["color"].lower()]
+            finding.severity = self.code_quality_severity[row["color"].lower()]
         else:
-            finding["severity"] = "info"
+            finding.severity = "info"
 
         if row["file"]:
-            finding["location"]["path"] = row["file"]
+            finding.path = row["file"]
         if "line" in row:
-            finding["location"]["positions"]["begin"]["line"] = int(row["line"])
+            finding.line = int(row["line"])
         if "col" in row:
-            finding["location"]["positions"]["begin"]["column"] = int(row["col"])
-        finding["description"] = description
-        exclude = ("new", "status", "severity", "comment", "key")
-        row_without_key = [value for key, value in row.items() if key not in exclude]
-        finding["fingerprint"] = hashlib.md5(str(row_without_key).encode('utf-8')).hexdigest()
-        self.cq_findings.append(finding)
+            finding.column = int(row["col"])
+
+        self.cq_findings.append(finding.to_dict())
 
     def check(self, content):
         '''

src/mlx/warnings/warnings.py

@@ -12,6 +12,7 @@
 
 from ruamel.yaml import YAML
 
+from .code_quality import Finding
 from .exceptions import WarningsConfigError
 from .junit_checker import JUnitChecker
 from .regex_checker import CoverityChecker, DoxyChecker, SphinxChecker, XMLRunnerChecker
@@ -277,6 +278,7 @@ def warnings_wrapper(args):
                         help='Possible not-used flags from above are considered as command flags')
 
     args = parser.parse_args(args)
+    Finding.fingerprints = {}  # Make sure the class variable is an empty dict
     code_quality_enabled = bool(args.code_quality)
     # Read config file
     if args.configfile is not None: