Windows / Lists show hidden content when moved/resized

[AvajiOT]

Priority

Medium

Area

• Data
• Source
• Docker
• Other

What happened?

When moving windows, any widget that is has hidden content being farther down the widget then the size of the widget will constantly flash when the client is drawing more than 60 frames per second.

Example with the client locked to 60;
https://github.com/mehah/otclient/assets/103899149/fe9acfea-bbae-45fe-828d-c3eb595a463c

When client is at 144FPS;
https://github.com/mehah/otclient/assets/103899149/8c8d7fc6-5522-4369-87b2-4711c6ff9b98

What OS are you seeing the problem on?

Windows

Code of Conduct

• I agree to follow this project's Code of Conduct

[conde2]

This is from the feat attached widget, sorry I'm on my cellphone.

Can you revert this changes and see if it fixes?

Only the changes related to setRect.

[AvajiOT]

I spent a bit of time and kept walking back commits until I no longer saw the issue, at commit fix widget shader it was not seen, however at commit build: compile fix it was seen.

Most commits after this one actually made the problem slightly worse, as I was not able to observe the issue of the inventory items flashing while resizing the window at the commit build: compile fix, however when moving the window around items were able to be seen.

Here's a quick video at 144 FPS at the commit build: compile fix
https://github.com/mehah/otclient/assets/103899149/0452e317-c6a8-49cd-98f1-690f9ce5619c

Quick video at commit fix widget shader
https://github.com/mehah/otclient/assets/103899149/b0ef5eae-28e9-46cd-8f90-1e3bcc307396

I was unable to build at v8 bot, but I suspect the problem first started appearing there.

[patrykq112]

I confirm that this bug exists. I think this is a bug related to Drawpool 3.0, not widgets

[EdwKing]

I confirm that this bug exists. I think this is a bug related to Drawpool 3.0, not widgets

Please try to revert to commit before drawpool 3.0 and see if you still see the issue. It seems to possibly be a combination of a couple things

Here's a recording of commit 674ad54 fix: function getItemCountOrSubType does not exist

commit.function.getitemcountorsubtype.does.not.exist.mp4

Possible that the inventory issue happens after the drawpool 3.0 update, but the text issues happen after v8 bot update.

[kokekanon]

I confirm that this bug exists. I think this is a bug related to Drawpool 3.0, not widgets

Please try to revert to commit before drawpool 3.0 and see if you still see the issue. It seems to possibly be a combination of a couple things

Here's a recording of commit 674ad54 fix: function getItemCountOrSubType does not exist

commit.function.getitemcountorsubtype.does.not.exist.mp4
Possible that the inventory issue happens after the drawpool 3.0 update, but the text issues happen after v8 bot update.

to find out if bug was the bot
I put the bot in version 3.11 and I can't reproduce that error in miniwindows or panellist

with 60 fps
144 fps

and max fps

[AvajiOT]

I confirm that this bug exists. I think this is a bug related to Drawpool 3.0, not widgets

Please try to revert to commit before drawpool 3.0 and see if you still see the issue. It seems to possibly be a combination of a couple things
Here's a recording of commit 674ad54 fix: function getItemCountOrSubType does not exist
commit.function.getitemcountorsubtype.does.not.exist.mp4
Possible that the inventory issue happens after the drawpool 3.0 update, but the text issues happen after v8 bot update.

to find out if bug was the bot I put the bot in version 3.11 and I can't reproduce that error in miniwindows or panellist

with 60 fps 144 fps

and max fps

Apologize for pushing the issue, but I just pulled the commit b0d5ff1 / build: compile fix , compiled it right now and tested it out.

otclient_x64_AOF3DRnkRg.mp4

If someone else could also test, to see if it's just completely localized to my compiler somehow that would be helpful

[conde2]

Fixed in:
e131c7d