Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird characters questlog #1061

Closed
2 of 5 tasks
gojtan opened this issue Jan 20, 2025 · 4 comments · Fixed by #1062
Closed
2 of 5 tasks

Weird characters questlog #1061

gojtan opened this issue Jan 20, 2025 · 4 comments · Fixed by #1062
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@gojtan
Copy link

gojtan commented Jan 20, 2025

Priority

Low

Area

  • Data
  • Source
  • Docker
  • Other

What happened?

For some reason questlog sometimes shows weird characters. Any clue why this would be?
Nothing wrong in my quests.xml what I can see, works fine in other OTClients

Image

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@gojtan gojtan added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 20, 2025
@github-actions github-actions bot added Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing labels Jan 20, 2025
@kokekanon
Copy link
Collaborator

kokekanon commented Jan 20, 2025

are you in the main repo ? , how to reproduce it ?

Image

Image

@gojtan
Copy link
Author

gojtan commented Jan 20, 2025

Yes, main repo. Some entries work fine, some don't. Haven't really figured out whats actually causing the issue, therefor I'm not really any help at reproducing it.

I'm going to try a fresh distro tommorrow and see if any of my tfs-changes can be the villain in the scenario.

Image

Image

@BastardofWinterfell
Copy link
Contributor

BastardofWinterfell commented Jan 21, 2025

I also have all kinds of issues with the quest log:

  • incorrect or cut off quest and mission titles,
  • incorrect or cut off quest and mission descriptions,
  • descriptions being displayed in the place of the quest title,
  • incorrectly ordered quests and missions,
  • etc.

These are definitely client issues as I don't have any of them with the questlog on OTCv8 (see comparison images below).

Image
Image
Image
Image
Image

I know for a fact that the quest log used to work correctly not too long ago. I'm not sure, but I believe these issues might have arisen due to the changes from #958 fix: packets in game_questlog and game_outfit which may have messed up the questlog in older protocols.

Environment

Using: Unmodified latest main (commit 7025f9e)
Client: OpenGL x64 compiled using VS Solution
Operating System: Windows
Server/Protocol: TFS-based 10.41

@kokekanon
Copy link
Collaborator

kokekanon commented Jan 21, 2025

test #1062

Image

Eventually, when TypeScript is incorporated into Lua, I will make the Quest Log module of 14.10.

@kokekanon kokekanon linked a pull request Jan 21, 2025 that will close this issue
13 tasks
@mehah mehah closed this as completed in 8302dbd Jan 21, 2025
vllworldbuilding pushed a commit to vllworldbuilding/otclient that referenced this issue Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants