Skip to content

Commit 3e181c4

Browse files
authored
feat: allow sandboxing for compilation rules (ocaml#10550)
Signed-off-by: Antonio Nuno Monteiro <[email protected]>
1 parent ba2da8b commit 3e181c4

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

src/dune_rules/compilation_context.ml

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -144,14 +144,7 @@ let create
144144
then Memo.Lazy.force requires_link
145145
else requires_compile
146146
in
147-
let sandbox =
148-
(* With sandboxing, there are a few build errors in ocaml platform 1162238ae
149-
like: File "ocaml_modules/ocamlgraph/src/pack.ml", line 1: Error: The
150-
implementation ocaml_modules/ocamlgraph/src/pack.ml does not match the
151-
interface
152-
ocaml_modules/ocamlgraph/src/.graph.objs/byte/graph__Pack.cmi: *)
153-
Sandbox_config.no_sandboxing
154-
in
147+
let sandbox = Sandbox_config.no_special_requirements in
155148
let modes =
156149
let default =
157150
{ Lib_mode.Map.ocaml = Mode.Dict.make_both (Some Mode_conf.Kind.Inherited)
@@ -168,7 +161,7 @@ let create
168161
in
169162
let ocamldep_modules_data : Ocamldep.Modules_data.t =
170163
{ dir = Obj_dir.dir obj_dir
171-
; sandbox = Sandbox_config.no_special_requirements
164+
; sandbox
172165
; obj_dir
173166
; sctx = super_context
174167
; vimpl

0 commit comments

Comments
 (0)