-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emphasis nodes not working with surrounded Chinese chars and Chinese punctuations #2580
Comments
Duplicate of remarkjs/remark#1107 |
Hi! This was closed. Team: If this was fixed, please add |
This is how markdown works in the CommonMark standard. |
I filed this issue because I have a gatsbyjs@v2 site that renders the above text as expected, as far as I know, it uses the @mdx-js/mdx too (but at v1.x). Now it can not work as expected with mdx v3, so I was thinking maybe it's a regression or something. |
No it's an improvement; this is how commonmark works everywhere, in MDX since then now too |
@weareoutman Could you try https://www.npmjs.com/package/remark-cjk-friendly plugin for the time being?
remark used in MDX v1 has not implemented this problematic feature yet. https://docusaurus.io/docs/migration/v3#emphasis-starting-or-ending-with-a-space-or-a-punctuation |
Initial checklist
Affected package
@mdx-js/[email protected]
Steps to reproduce
Go to the official playground and paste:
It generates:
Actual behavior
With surrounded Chinese chars and Chinese punctuations, no emphasis nodes been generated.
Have to add spaces around the
*
to make it work.Expected behavior
Expect to generate an emphasis node in the document.
Runtime
No response
Package manager
No response
Operating system
No response
Build and bundle tools
No response
The text was updated successfully, but these errors were encountered: