Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting in SLSQP output file #378

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Fix formatting in SLSQP output file #378

merged 1 commit into from
Jan 31, 2024

Conversation

eirikurj
Copy link
Contributor

Purpose

Output file formatting is inconsistent and missing characters in ALGORITHM

   ---------------------------------------------------------------------------
     START OF THE SEQUENTIAL LEAST SQUARES PROGRAMMING ALGORIT  
   ---------------------------------------------------------------------------

     PARAMETERS:
        ACC =   0.1000D-05
        MAXITER =500
        IPRINT =   1
IOUT =  60

This PR adjusts the output and after it should look

   ---------------------------------------------------------------------------
     START OF THE SEQUENTIAL LEAST SQUARES PROGRAMMING ALGORITHM
   ---------------------------------------------------------------------------

     PARAMETERS:
        ACC =   0.1000D-05
        MAXITER = 500
        IPRINT =   1
        IOUT =  60

Expected time until merged

No rush

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Run SLSQP optimization before and after the fix and compare outpu

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eirikurj eirikurj requested a review from a team as a code owner January 31, 2024 15:12
@eirikurj eirikurj requested review from sseraj and ArshSaja January 31, 2024 15:12
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eee3f70) 73.35% compared to head (43bbadc) 73.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #378   +/-   ##
=======================================
  Coverage   73.35%   73.35%           
=======================================
  Files          22       22           
  Lines        3318     3318           
=======================================
  Hits         2434     2434           
  Misses        884      884           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcomangano marcomangano merged commit 7f26d43 into main Jan 31, 2024
13 checks passed
@marcomangano marcomangano deleted the fixSLSQPFileIO branch January 31, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants