You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
writeSubfaceFamily call does not work if the target BC is already defined as a collection of patches. This check to find the target BC only picks up the first patch:
# Locate the Boco we're replacing
boco = None
for i in range(len(self.blocks[blockID].bocos)):
r = self.blocks[blockID].bocos[i].ptRange # get the point range for existing boco
if (
(r[0][0] == r[0][1] == 1 and face == "ilow")
or (r[0][0] == r[0][1] == self.blocks[blockID].dims[0] and face == "ihigh")
or (r[1][0] == r[1][1] == 1 and face == "jlow")
or (r[1][0] == r[1][1] == self.blocks[blockID].dims[1] and face == "jhigh")
or (r[2][0] == r[2][1] == 1 and face == "klow")
or (r[2][0] == r[2][1] == self.blocks[blockID].dims[2] and face == "khigh")
):
boco = i
break
If a grid comes from a parallel pyHyp run (most of our volume grids), then the BC is written in patches that are divided during the parallel load balancing. As a result, the writeSubfaceFamily only works if it is preceded by a complete overwrite of BCs.
Expected behavior
The writeSubFaceFamily should first find all patches on a BC, and overwrite all of it. This should be communicated in the documentation as well.
Code versions
Operating System:
Python:
OpenMPI:
CGNS:
PETSc:
Compiler:
This repository:
The text was updated successfully, but these errors were encountered:
Description
writeSubfaceFamily call does not work if the target BC is already defined as a collection of patches. This check to find the target BC only picks up the first patch:
https://github.com/mdolab/cgnsutilities/blob/main/cgnsutilities/cgnsutilities.py#L391-L404
If a grid comes from a parallel pyHyp run (most of our volume grids), then the BC is written in patches that are divided during the parallel load balancing. As a result, the writeSubfaceFamily only works if it is preceded by a complete overwrite of BCs.
Expected behavior
The writeSubFaceFamily should first find all patches on a BC, and overwrite all of it. This should be communicated in the documentation as well.
Code versions
The text was updated successfully, but these errors were encountered: