Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAS does not work with Numpy 2.1.3 #448

Open
sabakhshi opened this issue Nov 27, 2024 · 2 comments
Open

OAS does not work with Numpy 2.1.3 #448

sabakhshi opened this issue Nov 27, 2024 · 2 comments

Comments

@sabakhshi
Copy link
Contributor

Description

Running any OAS script with Numpy 2.1.3(or any version >=2.0) will not work.

Steps to reproduce issue

  1. Run most existing OAS scripts

Current behavior

Script fails to run since np.product was changed to np.prod in Numpy 2.0

Expected behavior

The scripts should run correctly

Code versions

  • Operating System: Any
  • Python: 3.10
  • OpenMPI: N/A
  • CGNS: N/A
  • PETSc: N/A
  • Compiler: N/A
  • This repository:
@A-CGray
Copy link
Member

A-CGray commented Nov 27, 2024

Seems like you could just do a blanket find and replace of np.product with np.prod to fix this, np.prod has been around for a long time so this shouldn't break anything

@sabakhshi
Copy link
Contributor Author

sabakhshi commented Dec 2, 2024

I fixed the issue. It was just one line. However a lot of tests are now failing. Some of the result are just a bit out of tolerance. I need to go through all and see if it's a small thing or if there are major issues.

Update: OAS looks to have issue with the latest OpenMDAO version. The issue has been identified and a fix is in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants