Support RabbitMQ 3.7.*

[bobindah]

Hi,
I am having problems with compiled version 1.04 (erlang 19.4) after upgrading RabbitMQ:

Recently upgraded our RabbitMQ to a newer version now running 3.7.3 and this seems to cause the rabbitMQ stamp plugin to no longer work. (previous server was 3.6.6 and it was fine)
Erlang version 20.1.
Crash Report states:
"exited with reason: no function clause matching rabbit_stamp_exchange"

Truncated Log Entry: [{file,"src/rabbit_stamp_exchange.erl"},{line,25}]},{rabbit_exchange,route1,3,[{file,"src/rabbit_exchange.erl"},{line,397}]},{rabbit_exchange,route,2,[{file,"src/rabbit_exchange.erl"},{line,387}]},{rabbit_channel,handle_method,3,[{file,"src/rabbit_channel.erl"},{line,1100}]},{rabbit_channel,handle_cast,2,[{file,"src/rabbit_channel.erl"},{line,523}]},{gen_server2,handle_msg,2,[{file,"src/gen_server2.erl"},{line,1047}]},{proc_lib,wake_up,3,[{file,"proc_lib.erl"},{line,257}]}]}
Offender: [{pid,<0.13736.44>},{name,channel},{mfargs,{rabbit_channel,start_link,[3,<0.14151.44>,

(I assume this is due to some breaking changes in the newer version of RabbitMQ)
Do you have any plans to support newer versions RabbitMQ?
Or is it as simple as building the plugin to target the newer version - If so I am happy to try that myself.

[mdevilliers]

Hey - I might have some time later this week to look at this.

Try building it yourself in the meantime and seeing if the error is consistent with what you are experiencing here in the meantime. It's not 100 % clear from the log entry what the issue could be but I think its the route function.

Mark

[bobindah]

Thanks for the reply - when I pull the repo as it is, I got the build running with make but when I run make test it tells me "ranch.app" is not found? - most likely I have something set up wrong. (I am using the vagent script linked in)
Yes it looks to me like the error is around the route function (it appears to error on line 25 of rabbit_stamp_exchange.erl)
I couldn't see any breaking changes in the latest RabbitMQ with this but it doesn't seem to like it.

Looking at the version of the SignalR rabbit plugin we are using is quite an old one (2.23) it is not the latest (2.28) so I am going to look into that as well as it may well the issue.

[bobindah]

Hi - Just to confirm - I managed to get a version built that seems to work correctly - Not sure if my method is entirely the right method but it works! Not sure it's worthy of a pull request as I don't know if I did it right!
I altered the Makefile (current_rmq_ref = rabbitmq_v3_7_3 - not sure if this is necessary)
I then replaced the rabbitmq-components.mk file with one from the "RabbitMQ Timestamp" plugin this file:
(https://github.com/rabbitmq/rabbitmq-message-timestamp/blob/master/rabbitmq-components.mk) as I knew that plugin works on the latest version.
then running:
make tests - 2 tests passed
make
make dist - I get a compiled version of the RabbitMQ stamp .es file that works with my setup (RabbitMQ 3.7.3, SignalR.RabbitMQ version 2.2.3 (had to use this version due to other project dependancies on rabbitMQ client version)
Thanks :)

[mdevilliers]

Great news. If you had time for a pr I would really appreciate it. It sounds like we will need to do the same things you did.

[bobindah]

No problem, I'll try and push something up on Monday.

[chazt3n]

@bobindah @mdevilliers any update on this?

[mdunc]

I submitted a PR to the fix-build branch with 2 small fixes. It builds and runs fine for us in Rabbit 3.7.4 and tests pass.

[mhellsten]

Any chance that you will build this and upgrade the SignalR.RabbitMq project with it? I really need it for a RabbitMQ 3.7.4 cluster and don't have any experience with Erlang builds. Thanks!

[mdevilliers]

@mhellsten check out #20
If you do have time to test could you please feedback?
Thanks,

Mark

[mhellsten]

@mdevilliers Very happy to test it for you! Any chance you can get me a build? I don't have any experience with building Erlang code, so that's my only concern. We got our current build from the SignalR.RabbitMq repo. Thanks!

[mhellsten]

@mdevilliers: I'm sorry, I just realized you already created one. I'm testing it with 3.7.5.

[BrettAus05]

Hi @mdevilliers, hope you don't mind me asking, but does your plugin work with the v3.8.1 of RabbitMQ? I've been reading up on the 'make' process, but it might as well be written in Chinese for this lowly C# developer :(

(Sorry, I didn't know if this question should be in a new 'issue' or not)

[mdunc]

@BrettAus05, we've only done some light testing, but the build we use for 3.7 seems to work just fine on 3.8 so far.