-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to specify version tag prefix #1
Comments
@mbdevpl: Are you watching this repo? Or should I go somewhere else to collaborate? |
@bryceschober Hi! I'm watching it, but somehow the previous notification got lost among other updates... Thanks for the interest in this project :) Yes, customization of the version tag prefix seems like a useful addition. Do you have any specific project in mind at the moment? |
@mbdevpl Not a public one, but an example would be a mono-repo that was the point of development for a few modestly-independent libraries in which the maintainer might separate semantic version streams for each library. |
@bryceschober I think this feature needs a use case - I don't think testing it on exclusively synthetic examples is a good idea. So by all means, if you have a specific open source use case in mind, please let me know here. Apart from the testing, do you have any idea how this feature's API might look? |
I agree about a concrete use case. A usage should be optional, of course: version_query.set_prefix_to_ignore("subproject-foo-")
version_string = version_query.query_version_str() # given tag "subproject-foo-v1.3.9" yields "1.3.9" And I could imagine that the implementation might be as simple as removing the prefix at the beginning of |
Oh, and I found a public open-source example: https://github.com/stellar/go |
@mbdevpl So I've experimented with a painfully awkward attempt at implementing this, and here's my hacky-crap version: master...DynonAvionics:master Some notes:
|
In order to bring this tool to bear in repos that might have been tagged in a different way, it'd be nice to be able to specify a prefix or even a list of prefixes for tags to include in the processing.
The text was updated successfully, but these errors were encountered: