Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/4 producttypecode #28

Merged
merged 19 commits into from
Jan 29, 2025
Merged

Feature/4 producttypecode #28

merged 19 commits into from
Jan 29, 2025

Conversation

Floris272
Copy link
Contributor

Fixes #

Changes

  • adds productype code
  • adds organisatie code
  • adds producttype toegestane_statussen
  • adds product status
  • adds celery
  • adds logging app (from https://github.com/GPP-Woo/GPP-publicatiebank)
  • adds task that changes the product status based on start_datum & eind_datum

@Floris272 Floris272 linked an issue Jan 10, 2025 that may be closed by this pull request
Producttypecode toevoegen aan ProductType, unieke identificatie #4
Closed
@Floris272 Floris272 force-pushed the feature/4-producttypecode branch from 14a7eef to e8df71d Compare January 10, 2025 13:01
This was linked to issues Jan 10, 2025
Organisatie aanvullen met code, organisatiecode #7
Closed
Product & producttype statussen #10
Closed
@Floris272 Floris272 force-pushed the feature/4-producttypecode branch from 8e19560 to c0b1163 Compare January 21, 2025 09:54
@Floris272 Floris272 marked this pull request as ready for review January 21, 2025 10:01
@Floris272 Floris272 requested a review from Coperh January 21, 2025 11:15
@Floris272 Floris272 mentioned this pull request Jan 27, 2025
Open
Coperh
Coperh reviewed Jan 27, 2025
View reviewed changes
Copy link

@Coperh Coperh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly fine I think.
Few questions about status validation for setting based on the date.

Also I was pretty lazy reviewing the logging app.

src/open_producten/producten/urls.py Outdated Show resolved Hide resolved
src/open_producten/producttypen/tests/api/test_producttype.py Outdated Show resolved Hide resolved
src/open_producten/utils/checks.py Outdated Show resolved Hide resolved
src/open_producten/producttypen/models/producttype.py Outdated Show resolved Hide resolved
...n/producttypen/migrations/0005_producttype_code_producttype_toegestane_statussen_and_more.py Show resolved Hide resolved
src/open_producten/producten/tasks.py Show resolved Hide resolved
src/open_producten/producten/admin/product.py Show resolved Hide resolved
src/open_producten/producten/tests/test_product.py Outdated Show resolved Hide resolved
src/open_producten/producten/tests/test_product.py Show resolved Hide resolved
src/open_producten/producten/tests/test_product.py Show resolved Hide resolved
@Floris272 Floris272 merged commit 19d66ce into master Jan 29, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Coperh Coperh Coperh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Floris272 @Coperh