diff --git a/src/open_inwoner/accounts/tests/test_profile_views.py b/src/open_inwoner/accounts/tests/test_profile_views.py index 09ab150a83..dae0f9e58d 100644 --- a/src/open_inwoner/accounts/tests/test_profile_views.py +++ b/src/open_inwoner/accounts/tests/test_profile_views.py @@ -223,7 +223,7 @@ def test_info_eherkenning_user(self): doc = PQ(response.content) business_section = doc.find("#business-overview")[0] - self.assertEqual(business_section.text, "Bedrijfsgegevens") + self.assertEqual(business_section.text.strip(), "Bedrijfsgegevens") # check personal overview section not displayed personal_section = doc.find("#personal-overview") @@ -290,6 +290,7 @@ def setUp(self): self.url = reverse("profile:edit") self.return_url = reverse("profile:detail") self.user = UserFactory() + self.eherkenning_user = eHerkenningUserFactory() def upload_test_image_to_profile_edit_page(self, img_bytes): response = self.app.get(self.url, user=self.user, status=200) @@ -394,6 +395,17 @@ def test_modify_email_succeeds(self): self.assertEqual(response.url, self.return_url) self.assertEqual(self.user.email, "user@example.com") + def test_modify_contact_details_eherkenning_succeeds(self): + response = self.app.get(self.url, user=self.eherkenning_user) + form = response.forms["profile-edit"] + form["email"] = "user@example.com" + form["phonenumber"] = "0612345678" + response = form.submit() + self.eherkenning_user.refresh_from_db() + self.assertEqual(response.url, self.return_url) + self.assertEqual(self.eherkenning_user.email, "user@example.com") + self.assertEqual(self.eherkenning_user.phonenumber, "0612345678") + def test_updating_a_field_without_modifying_email_succeeds(self): initial_email = self.user.email initial_first_name = self.user.first_name @@ -633,7 +645,7 @@ def test_modify_phone_updates_klant_api_but_skip_unchanged_email(self, m): ) @requests_mock.Mocker() - def test_modify_phone_updates_klant_api_but_skip_unchanged_phone(self, m): + def test_modify_email_updates_klant_api_but_skip_unchanged_phone(self, m): MockAPIReadPatchData.setUpServices() data = MockAPIReadPatchData().install_mocks(m) diff --git a/src/open_inwoner/templates/pages/profile/edit.html b/src/open_inwoner/templates/pages/profile/edit.html index 4c3ddf8cd0..a07e4b928a 100644 --- a/src/open_inwoner/templates/pages/profile/edit.html +++ b/src/open_inwoner/templates/pages/profile/edit.html @@ -23,7 +23,10 @@

{% csrf_token %} {% with request.user as user %} - {% if user.is_digid_user_with_brp %} + {% if user.is_eherkenning_user %} + {% input form.email %} + {% input form.phonenumber %} + {% elif user.is_digid_user_with_brp %} {% input form.display_name %} {% input form.email %} {% input form.phonenumber %} diff --git a/src/open_inwoner/templates/pages/profile/me.html b/src/open_inwoner/templates/pages/profile/me.html index aedaf0d920..1378058eb0 100644 --- a/src/open_inwoner/templates/pages/profile/me.html +++ b/src/open_inwoner/templates/pages/profile/me.html @@ -21,7 +21,11 @@

{% trans "Welkom" %}{% if not user.is_eherkenning_user {# Business information #}
-

{% trans "Bedrijfsgegevens" %}

+

{% trans "Bedrijfsgegevens" %} +
+ {% button href="profile:edit" text=_("Bewerk") icon="edit" transparent=True icon_outlined=True %} +
+

{% trans "Handelsnaam" %}
@@ -38,6 +42,14 @@

{% trans "Bedrijfsgegevens" %}

{{ user.postcode }} {{ user.city }}
+
+
{% trans "E-mail adres" %}
+
{{ user.email }}
+
+
+
{% trans "Telefoonnummer" %}
+
{{ user.phonenumber }}
+
{% else %} {# Personal information #}