Feature/#554 filter destruction lists #572
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenvandescheur
force-pushed
the
feature/#554-filter-destruction-lists
branch
from
50661f6 to
eec7128
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
==========================================
+ Coverage 84.18% 84.30% +0.12%
==========================================
Files 208 212 +4
Lines 5639 5716 +77
Branches 570 576 +6
==========================================
+ Hits 4747 4819 +72
- Misses 892 897 +5 ☔ View full report in Codecov by Sentry. |
svenvandescheur
force-pushed
the
feature/#554-filter-destruction-lists
branch
12 times, most recently
from
f7e024e to
e54e2b7
Compare
SilviaAmAm
reviewed
Dec 20, 2024
Comment on lines
+20
to
+24
| class UsersView(ListAPIView): | ||
| serializer_class = UserSerializer | ||
|
|
||
| def get_queryset(self) -> QuerySet[User]: | ||
| return User.objects.all() |
There was a problem hiding this comment.
Is there a reason for not doing:
Suggested change
| class UsersView(ListAPIView): | |
| serializer_class = UserSerializer | |
| def get_queryset(self) -> QuerySet[User]: | |
| return User.objects.all() | |
| class UsersView(ListAPIView): | |
| serializer_class = UserSerializer | |
| queryset = User.objects.all() |
There was a problem hiding this comment.
- For endpoints using the manager method that filter on permissions, this may cause issues when initializing as the queryset is initialized straight away.
- For the this particular case its uses the get_queryset method for consistency.
There was a problem hiding this comment.
These endpoints are getting a bit out of hand, maybe we should refactor to use filters?
So then we would have GET /api/v1/users?role=reviewer ?
| return self._users_with_permission(permission) | ||
|
|
||
| def _users_with_permission(self, permission: Permission) -> "UserQuerySet": | ||
| return self.filter( # noqa |
There was a problem hiding this comment.
My IDE resolves the type to be QuerySet but AFAIK if executed in this context it will return a UserQuerySet.
svenvandescheur
force-pushed
the
feature/#554-filter-destruction-lists
branch
from
e54e2b7 to
06c06e7
Compare
… name, status, author, reviewer and assignee
…n name, status, author, reviewer and assignee
svenvandescheur
force-pushed
the
feature/#554-filter-destruction-lists
branch
from
06c06e7 to
103afe9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #554