[#469] Reduce db/HTTP connections #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #626 +/- ##
==========================================
- Coverage 88.35% 88.32% -0.03%
==========================================
Files 210 210
Lines 6043 6074 +31
Branches 639 639
==========================================
+ Hits 5339 5365 +26
- Misses 704 709 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SilviaAmAm
force-pushed
the
fix/469-reduce-db-connections
branch
from
eb9108b to
8025100
Compare
- Avoid retrieving the selectielijst service for each zaak - Take advantage of connection pooling by sharing client between zaken
SilviaAmAm
force-pushed
the
fix/469-reduce-db-connections
branch
from
8025100 to
5507b62
Compare
svenvandescheur
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #469
I notices that there is quite a lot of duplication between the tasks
retrieve_and_cache_zaken_from_openzaakandresync_zaken.I will make a separate PR to refactor that, to make it easier to review. #627