Objecten API: Permission admin view is slow

[alextreme]

Product versie / Product version

2.4.4

Omschrijf het probleem / Describe the bug

Taiga DH 596

Adding a new permission in the Objects API for DH currently takes ~12 seconds, this because of the retrieval of all the objecttypes on every pageload.

For further details and an APM trace please see the Taiga issue

Stappen om te reproduceren / Steps to reproduce

No response

Verwacht gedrag / Expected behavior

No response

[joeribekker]

W're doing an initial analysis before estimating (1-2 hours).
Please put back the ticket in triage with the analysis.

[annashamray]

Analysis:
What happens

This happens because of field-based authorization option. On this page if you check "Use field-based authorization", then all fields of all versions of the selected objecttype would be displayed.
So under the hood each of the objecttypes is requested in this method:

objects-api/src/objects/token/admin.py

Line 39 in f8c6944

def get_data_field_choices(self):

We can't use LIST objecttypes endpoint, because it doesn't have version data, so we use /api/v2/objecttypes/{objecttype_uuid}/versions endpoint for each objecttype uuid.

How to improve it

1. Now we request all objecttypes before the page is loaded, even if only one would be eventually selected.
   Perhaps we can just request a particular objecttype which is selected in the form. So there should be required some React coding, like having an internal rest endpoint which FE requests which has objecttype id as a parameter.

2. If field-based auth is not used it can be turned off globally (for example via env var), and this problem would be solved very easily.

[joeribekker]

So, only load in objecttype details when: 1) an objecttype is selected and 2) field based auth is checked. Only then load in the field based permission checkboxes.

Estimated: 3 days

[joeribekker]

@PeterVanBragt approval needed

[PeterVanBragt]

How can I tag Jan Verbeek in this ticket? I would like him to check the business value against the costs for resolving (and check with him if there's a sponsor for this).

[alextreme]

Dit kan met @VerbeekIT als het goed is

[PeterVanBragt]

@VerbeekIT - Checking the business value against the costs for resolving - what do you think? And do you know a sponsor for this?

[VerbeekIT]

Ja dat lukt via VerbeekIT

[PeterVanBragt]

So, what exactly can be expected (performance wise) for this 3 day investment? Will 12 seconds become less then one?

[alextreme]

It will be less than 3 seconds to load the page, and most likely quicker

[PeterVanBragt]

Ok, approved (for max 3 day development time)