Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inViewport Relies on Normal Scroll Container #130

Open
jlukic opened this issue Oct 13, 2016 · 1 comment
Open

inViewport Relies on Normal Scroll Container #130

jlukic opened this issue Oct 13, 2016 · 1 comment

Comments

@jlukic
Copy link

jlukic commented Oct 13, 2016

When a Vivus element is in a scroll container using overflow: auto it will not appear because isInViewport uses document as the only possible scroll container.

This could be solved by allowing the settings object to specify a scrollContext for the SVG, or maybe allowing an option to disable isInViewport check.

@maxwellito
Copy link
Owner

Hi,
I see.. you're right, I never thought about this problem. But it means that the code should check that all parent nodes are in the viewport to trigger the animation...
However you can still stop the isInViewport check by using the option start: 'manual' or start: 'autostart' (but I'm not sure that's the behavior you expect)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants