Use classic linker w/ Xcode 15.0

See crystal-lang/crystal#13846

Unclear right now on if this is Crystal issue, LLVM issue, or something else

Author: maxfierke

Makefile

@@ -5,6 +5,7 @@ SHELL := bash
 .DELETE_ON_ERROR:
 .SUFFIXES:
 
+CRFLAGS           ?=
 CRYSTAL           ?= $(shell which crystal)
 SHARDS            ?= $(shell which shards)
 MESON             ?= $(shell which meson)
@@ -35,6 +36,15 @@ MESON_FLAGS ?= \
   $(if $(RELEASE),--buildtype=release --strip,--buildtype=debug) \
   $(if $(STATIC),--default-library=static,--default-library=shared)
 
+ifeq ($(shell command -v xcodebuild > /dev/null && echo true),true)
+  XCODE_VERSION := $(shell xcodebuild -version | awk '/Xcode/ {print $$2}' | tr -d '')
+
+  # Use legacy linker with xcode 15 for now
+  ifeq ($(XCODE_VERSION),15.0)
+    override CRFLAGS += --link-flags=-Wl,-ld_classic
+  endif
+endif
+
 # Add cross-files if target and host are different
 ifeq ($(shell [[ "$(TARGET_OS)" != "$(HOST_OS)" || "$(TARGET_ARCH)" != "$(HOST_ARCH)" || ! -z "$(TARGET_CABI)" ]] && echo true),true)
   override MESON_FLAGS += --cross-file=$(TARGET_CROSS_FILE)
@@ -99,7 +109,7 @@ format:
 	$(CRYSTAL) tool format
 
 lint: deps
-	$(CRYSTAL) bin/ameba.cr
+	$(CRYSTAL) run $(CRFLAGS) bin/ameba.cr
 
 .PHONY: clean
 clean:
@@ -111,7 +121,7 @@ clean:
 .PHONY: spec
 spec: deps $(SOURCES)
 	$(CRYSTAL) tool format --check
-	$(CRYSTAL) spec -Dmt_no_expectations --error-trace
+	$(CRYSTAL) spec $(CRFLAGS) -Dmt_no_expectations --error-trace
 
 .PHONY: check-libraries
 check-libraries: bin/mstrap

meson.build

@@ -9,6 +9,7 @@ project('mstrap',
   ]
 )
 
+cc = meson.get_compiler('c')
 target_arch = host_machine.cpu_family()
 target_system = host_machine.system()
 target_triple = target_arch + '-unknown-' + target_system
@@ -17,6 +18,7 @@ buildtype = get_option('buildtype')
 is_darwin = target_system == 'darwin'
 is_static = get_option('default_library') == 'static'
 is_static_libc = false
+needs_macos_classic_linker = false
 
 if target_system == 'linux'
   target_cabi = meson.get_external_property('target_triple_suffix', 'gnu')
@@ -34,9 +36,17 @@ elif target_system == 'darwin'
   target_triple = macos_arch + '-apple-macos' + macos_abi
   add_global_arguments('-target', target_triple, language : 'c', native : false)
   add_global_link_arguments('-target', target_triple, language : 'c', native : false)
+
+  # Use legacy linker with xcode 15+
+  xcode_version_output = run_command(find_program('xcodebuild'), '-version', check : true).stdout()
+  xcode_version = xcode_version_output.split('\n').get(0, '').replace('Xcode', '').strip()
+
+  if xcode_version.version_compare('>=15.0') and cc.has_link_argument('-Wl,-ld_classic')
+    needs_macos_classic_linker = true
+    add_global_link_arguments('-Wl,-ld_classic', language : 'c')
+  endif
 endif
 
-cc = meson.get_compiler('c')
 crystal = find_program(get_option('crystal'), required : true)
 shards = find_program(get_option('shards'), required : true)
 
@@ -157,6 +167,10 @@ if is_static_libc
   crystal_build_flags += ['--static']
 endif
 
+if needs_macos_classic_linker
+  crystal_build_flags += ['--link-flags=-Wl,-ld_classic']
+endif
+
 mstrap_build_cmd = [crystal, 'build'] + crystal_build_flags + ['-o', 'mstrap', '@INPUT@']
 
 mstrap_o = custom_target(