-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File download feature #190
base: master
Are you sure you want to change the base?
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hi @mattmezza, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a great addition @arabakevin ! You are the best!
There are some things that we could fix before merging :)
Please rebase on current master before starting to tackle this.
@a-kriya please feel free to chip in with your review too
…ture # Conflicts: # demo/src/App.vue
…ry to truncate name and calculate size of file
…tiful-chat into file_sharing_feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @arabakevin, I could not make it to work as you intended. Could you fix the demo such that it shows the changes you want to the lib to have?
refactorisation of method to truncate, calculate size and type of file, fixes syntaxes and download icon has been export as an asset svg
Hi @arabakevin , @a-kriya , |
…tiful-chat into file_sharing_feature
Hi, |
@@ -67,6 +77,7 @@ | |||
<script> | |||
import TextMessage from './messages/TextMessage.vue' | |||
import FileMessage from './messages/FileMessage.vue' | |||
import ImageMessage from './messages/ImageMessage.vue' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
#173