When link tooltip fails to load issue, the spinner continues to spin forever with no user feedback

[mickmister]

There's an issue happening on community where the OAuth tokens got potentially corrupted after migrating to hub, for reasons outside of the plugin's functionality, and now the plugin thinks I'm connected but the token doesn't work anymore.

failed to get Jira client for the user (my name): error in getting token from token source: oauth2: cannot fetch token: 403 Forbidden

The exact error here is not important, though we do want to surface any useful information returned from the response to the user. And possibly just not show the tooltip anymore when this happens.

[mickmister]

@matthewbirtch Do you have an opinion on how this should work? Essentially is the ticket fails to load, we show the spinning loading indicator, without any information for the user to know that something failed.

[matthewbirtch]

@matthewbirtch Do you have an opinion on how this should work? Essentially is the ticket fails to load, we show the spinning loading indicator, without any information for the user to know that something failed.

@mickmister I think we need to have a time out - definitely don't want it to infinitely load. If it isn't able to load within 30 seconds, we should show a failure message of some kind I think and possibly auto-hide the popover after that. Thoughts?

[mickmister]

@matthewbirtch The problem isn't that it's taking a long time to load, it's that an error occurs and the UI does not reflect the error. The UI instead just continues to show the spinner when the error occurs.

The main question I have here is, should we show an error in this case, and what error should be shown? Or should we just hide the popover and not show an error? In the case where the user's auth information is corrupted somehow (like described in the issue description), they will get an error for every issue they hover over, so we want to make sure the errors aren't too distracting in a case like this.

[matthewbirtch]

@mickmister I think it would be better to show an error rather than having the popover show momentarily and then disappear with no explanation.

I was thinking something like this. And it would auto-hide after 5 seconds once we show this state.

In the case where the auth information is corrupted, are we able to suppress showing the popover altogether from that point forward until resolved? I assume that may not be possible to detect though.