Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrying SSO does not trigger a redirect #8450

Open
kondo97 opened this issue Jan 6, 2025 · 1 comment
Open

Retrying SSO does not trigger a redirect #8450

kondo97 opened this issue Jan 6, 2025 · 1 comment
Labels
Bug Report/Open Bug report/issue

Comments

@kondo97
Copy link

kondo97 commented Jan 6, 2025

Summary

Retrying SSO does not trigger a redirect. The issue occurs because the server URL is being incorrectly registered as invalid.

Environment Information

Device Name: iPhone 16
OS Version: iOS 18
Mattermost App Version: v2.23.1

Steps to Reproduce

  1. Press the SSO button (e.g., GitLab). The browser opens.
  2. Press the cancel button on the top left. A "Sign-in error" message appears.
  3. Press "Try Again." The browser opens again.
  4. Log in via the IDP, and it redirects to the app.
  5. An "Authentication Successful" message appears, but the app does not redirect.

Expected behavior

Successful login

Observed behavior (that appears unintentional)

error on ssoLogin Received invalid response from the server.; Session for https://XXXXX.com has been invalidated
Failed to set store from local data [Error: Received invalid response from the server.]

Possible fixes

The server URL is being registered as invalid. I believe the logic on lines 50 and 51 is unnecessary. Even if the URL is valid upon retry, it is still being registered as invalid.

if (resetErrors !== false) {
setError('');
setLoginError('');
NetworkManager.invalidateClient(serverUrl);
NetworkManager.createClient(serverUrl);

@amyblais
Copy link
Member

amyblais commented Jan 6, 2025

Opened https://mattermost.atlassian.net/browse/MM-62411.

@amyblais amyblais added the Bug Report/Open Bug report/issue label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report/Open Bug report/issue
Projects
None yet
Development

No branches or pull requests

2 participants