You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
The V2 world goals (e.g., WorldGoalV2) need to be removed. After being deprecated according to #291
This also includes the adjustments of several lines in GridWorld.__check_simulation_goal, as the check between V2 and regular is not necessary anymore:
ifisinstance(self.__simulation_goal, (list, tuple)): # edited this check to include tuplesforsim_goalinself.__simulation_goal:
# Check if the goal is a new V2 goalifisinstance(sim_goal, WorldGoalV2):
is_done=sim_goal.goal_reached(world_state, self)
else:
is_done=sim_goal.goal_reached(world_state, self)
# Store goal statusgoal_status[sim_goal] =is_doneelse:
# Check if the goal is a new V2 goalifisinstance(self.__simulation_goal, WorldGoalV2):
is_done=self.__simulation_goal.goal_reached(world_state, self)
else:
is_done=self.__simulation_goal.goal_reached(world_state, self)
goal_status[self.__simulation_goal] =is_done
Describe the solution you would like
N/A
Describe alternatives you have considered
N/A
Additional context
The last step after #291 to allow for sufficient time to go for MATRX users to adapt to the V2 world goals and then to phase out the V2 back to normal naming.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
The V2 world goals (e.g.,
WorldGoalV2
) need to be removed. After being deprecated according to #291This also includes the adjustments of several lines in
GridWorld.__check_simulation_goal
, as the check between V2 and regular is not necessary anymore:Describe the solution you would like
N/A
Describe alternatives you have considered
N/A
Additional context
The last step after #291 to allow for sufficient time to go for MATRX users to adapt to the V2 world goals and then to phase out the V2 back to normal naming.
The text was updated successfully, but these errors were encountered: