Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove V2 Loggers #290

Open
jwaa opened this issue May 16, 2021 · 0 comments
Open

Remove V2 Loggers #290

jwaa opened this issue May 16, 2021 · 0 comments
Labels
core Work related to the core functionality request A request for a new feature

Comments

@jwaa
Copy link
Member

jwaa commented May 16, 2021

Is your feature request related to a problem? Please describe.
The V2 loggers (e.g., GridWorldLoggerV2) need to be removed. After being deprecated according to #289

This also includes the removal of these lines in GridWorld.__step, as the check is then no longer needed:

# Check if the logger is an old or V2 version.
if isinstance(logger, GridWorldLoggerV2):
    logger._grid_world_log(world_state=world_state, agent_data=agent_data_dict, grid_world=self,
                           last_tick=self.__is_done, goal_status=goal_status)
else:
    logger._grid_world_log(agent_data=agent_data_dict, grid_world=self,
                           last_tick=self.__is_done, goal_status=goal_status)

Describe the solution you would like
N/A

Describe alternatives you have considered
N/A

Additional context
The last step after #289 to allow for sufficient time to go for MATRX users to adapt to the V2 loggers and then to phase out the V2 back to normal naming.

@jwaa jwaa added core Work related to the core functionality request A request for a new feature labels May 16, 2021
@jwaa jwaa added this to the Release V2.3.0 milestone May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Work related to the core functionality request A request for a new feature
Projects
None yet
Development

No branches or pull requests

1 participant