Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to Definition on package name in call to package function opens package name, not function #16

Open
dklilley opened this issue Aug 15, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@dklilley
Copy link
Member

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Create the following files, one of which is in a package directory: somepath/+plot/doThing.m
    • somepath/+plot/doThing.m
    • somepath/sample.m
  2. In sample.m, make the following call: plot.doThing()
  3. Go-to-Definition on doThing - doThing.m opens correctly
  4. Go-to-Definition on plot - plot.m opens instead

Expected behavior
In the above example, it is expected that doThing.m will open.

Additional context
Will need to determine how to handle cases like the following: pkg.ClassName.funcName(). If Go-to-Definition is triggered on the class name, do we want to open the class definition? Going to the function definition would often go to the same file, unless it is implemented in a class folder.

Internal tracking number: g2885285

@dklilley dklilley added the bug Something isn't working label Aug 15, 2023
diningPhilosopher64 pushed a commit to diningPhilosopher64/MATLAB-language-server that referenced this issue Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant