Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container with theme class is created twice #818

Closed
artaommahe opened this issue Jan 6, 2025 · 5 comments · Fixed by #819 or #825
Closed

Container with theme class is created twice #818

artaommahe opened this issue Jan 6, 2025 · 5 comments · Fixed by #819 or #825

Comments

@artaommahe
Copy link

artaommahe commented Jan 6, 2025

Describe the bug

Since one of the dockview's updates there are two nested containers (divs) with theme class applied
To Reproduce

Steps to reproduce the behavior:

Expected behavior

only one div.dockview-theme-abyss is created

Screenshots

image

Desktop (please complete the following information):

  • Browser: Chrome
  • Version 131.0.6778.205 (Official Build) (arm64)

Additional context

We have some custom styles on top of the theme class and now they are applied twice

@mathuo mathuo linked a pull request Jan 6, 2025 that will close this issue
@mathuo
Copy link
Owner

mathuo commented Jan 9, 2025

Released in 3.0.1. Thanks for the find!

@artaommahe
Copy link
Author

artaommahe commented Jan 10, 2025

@mathuo looks like it's a bit broken with DockviewReact 😅 nothing is rendered

https://stackblitz.com/edit/vitejs-vite-gxtkfb71?file=src%2FApp.tsx

@mathuo mathuo linked a pull request Jan 10, 2025 that will close this issue
@mathuo
Copy link
Owner

mathuo commented Jan 10, 2025

Ah - seems to be an issue with rendering within React.StrictMode after that change, I knew there was a reason for it being there!

I've gone through and fixed this up in a new PR with additional tests around this area. Will test and release before the new week.

@mathuo
Copy link
Owner

mathuo commented Jan 11, 2025

Released in 3.0.2. Do let me know if that works for you

@artaommahe
Copy link
Author

@mathuo looks good, thx )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants