update names

Author: dario-coscia

pina/loss/ntk_weighting.py

@@ -39,7 +39,7 @@ def __init__(self, update_every_n_epochs=1, alpha=0.5):
 
         # Initialize parameters
         self.alpha = alpha
-        self.history = {}
+        self.weights = {}
 
     def weights_update(self, losses):
         """
@@ -62,7 +62,7 @@ def weights_update(self, losses):
 
         # Update the weights
         return {
-            condition: self.alpha * self.history.get(condition, 1)
+            condition: self.alpha * self.weights.get(condition, 1)
             + (1 - self.alpha)
             * losses_norm[condition]
             / sum(losses_norm.values())

pina/loss/weighting_interface.py

@@ -48,7 +48,7 @@ def __init__(self, update_every_n_epochs=1, aggregator="sum"):
         self._solver = None
         self.update_every_n_epochs = update_every_n_epochs
         self.aggregator_fn = aggregator
-        self.weights = {}
+        self._saved_weights = {}
 
     @abstractmethod
     def weights_update(self, losses):
@@ -82,11 +82,13 @@ def aggregate(self, losses):
         """
         # Update weights
         if self.solver.trainer.current_epoch % self.update_every_n_epochs == 0:
-            self.weights = self.weights_update(losses)
+            self._saved_weights = self.weights_update(losses)
 
-        # Aggregate
+        # Aggregate (without the .get() we force error
+        # if condition is not present in the returned dict)
         return self.aggregator_fn(
-            self.weights[condition] * loss for condition, loss in losses.items()
+            self._saved_weights[condition] * loss
+            for condition, loss in losses.items()
         )
 
     @property