Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BottomSheet] Widget.Material3.BottomSheet.Modal should have enableEdgeToEdge by default, otherwise there will be a gap at the system navigation bar if the app uses a custom theme #4367

Open
ashnohe opened this issue Nov 6, 2024 · 0 comments

Comments

@ashnohe
Copy link

ashnohe commented Nov 6, 2024

Widget.Material3.BottomSheet.Modal should have <item name="enableEdgeToEdge">true</item> by default for SDK 35+, otherwise there will be a gap at the system navigation bar if the app uses a custom theme that inherits from Widget.Material3.BottomSheet.Modal and targets SDK 35 (at which point edge-to-edge is enforced).

See attached images, one showing a gap without enableEdgeToEdge and without a gap with enableEdgeToEdge.

Screenshot 2024-11-01 at 5 26 17 PM Screenshot 2024-11-01 at 5 27 04 PM

The documentation should also be updated to talk about the new BottomSheet behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants