Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove batch.sh #243

Open
mateor opened this issue Dec 16, 2013 · 0 comments
Open

Remove batch.sh #243

mateor opened this issue Dec 16, 2013 · 0 comments

Comments

@mateor
Copy link
Owner

mateor commented Dec 16, 2013

Batch.sh has served several purposes

  • it kept download size lower back when every update needed to be downloaded seperately
  • It kept a back up of patches, so they could be reset after tinkering

But now that we have an auto-updater, the auto-patcher only needs to be downloaded once, and the git framework is more than capable of handling bad edits or corruption issues. Batch.sh is time expensive and has only gotten more so as we have 100x more files for each patch set nowadays.

What is needed to remove:

  • instead of unzipping, look for patches in dir above (or copy down, which seems unnecessary)
  • remove calls to batch.sh.

testing is needed. But I think the compressing/uncompressing is about a third of the run time, which is significant on the standard power computers (4 gigs of ram, maybe)

@ghost ghost assigned mateor Dec 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant