implemented the task by creating all the classes and methods #1716
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this task! 😊 However, there are a few critical issues that need to be addressed before we can approve your submission. The Ball, Colors, and Lottery classes are missing, which are essential components of the task. These classes are crucial for the functionality of your application as they define the core logic and structure. Please implement these classes with the necessary fields and methods as described in the task requirements. Once these changes are made, your solution will be much closer to completion. Keep up the great effort, and don't hesitate to reach out if you need any help! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
There was a problem hiding this comment.
Review Summary
🎉 Great job on implementing the required classes and methods! Your solution meets the task requirements and constraints, and all necessary components are present. Here are some highlights and suggestions for improvement:
-
Ball Class: Well-implemented with private fields and appropriate methods. The
toString()method is correctly overridden. No changes needed here. -
Colors Enum: Correctly defined with color constants. This is used effectively in the
ColorSupplierclass. -
ColorSupplier Class: Appropriately uses the
Randomclass to provide a random color from theColorsenum. Well done! -
Lottery Class: Generates a random
Ballobject with a random color and number. This is implemented correctly. -
Application Class: Successfully creates and prints three
Ballobjects. However, consider refactoring your code to use a loop for creating and printing the balls to avoid redundancy and improve maintainability.
Your code is functional, and the decision to approve is made to help you move forward with your learning. Please review the comments to improve your code, especially regarding the use of loops to create multiple objects. Addressing these suggestions will enhance your coding skills and help avoid similar issues in the future. Keep up the good work and continue learning! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| Lottery lottery = new Lottery(); | ||
| Ball firstBall = lottery.getRandomBall(); | ||
| System.out.println(firstBall); | ||
| Ball secondBall = lottery.getRandomBall(); | ||
| System.out.println(secondBall); | ||
| Ball thirdBall = lottery.getRandomBall(); | ||
| System.out.println(thirdBall); |
There was a problem hiding this comment.
Instead of creating each Ball object separately, consider using a loop to create and print the balls. This approach will make your code cleaner and more maintainable. Refer to the checklist for an example of how to use a loop for creating multiple objects .
No description provided.