created lottery #1692
Open
created lottery #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Great job on implementing the core functionality! 🎉 While there are a few areas for improvement, such as using a loop to create multiple Ball objects for better readability and maintainability, your code meets the task requirements. Keep up the good work and consider the suggestions for future enhancements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
Comment on lines
+6
to
+8
| Ball firstBall = Lottery.getRandomBall(); | ||
| Ball secondBall = Lottery.getRandomBall(); | ||
| Ball thirdBall = Lottery.getRandomBall(); |
There was a problem hiding this comment.
Consider using a loop to create multiple Ball objects instead of repeating the Lottery.getRandomBall() method call. This approach is recommended in the checklist to improve code readability and maintainability .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.