the ball lottery was created #1689
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elena-Bruyako
suggested changes
Nov 2, 2024
| private static final int NUMBER_OF_BALLS = 3; | ||
|
|
||
| public static void main(String[] args) { | ||
| // create three balls using class Lottery and print information about them in console |
Comment on lines
12
to
15
| Ball[] balls = new Ball[NUMBER_OF_BALLS]; | ||
| for (int i = 0; i < balls.length; i++) { | ||
| balls[i] = lottery.getRandomBall(); | ||
| System.out.println(balls[i].toString()); |
There was a problem hiding this comment.
Suggested change
| Ball[] balls = new Ball[NUMBER_OF_BALLS]; | |
| for (int i = 0; i < balls.length; i++) { | |
| balls[i] = lottery.getRandomBall(); | |
| System.out.println(balls[i].toString()); | |
| for (int i = 0; i < NUMBER_OF_BALLS; i++) { | |
| System.out.println(lottery.getRandomBall()); |
Comment on lines
4
to
10
| private Color color; | ||
| private int number; | ||
|
|
||
| public Ball(Color color, int number) { | ||
| this.color = color; | ||
| this.number = number; | ||
| } |
There was a problem hiding this comment.
Suggested change
| private Color color; | |
| private int number; | |
| public Ball(Color color, int number) { | |
| this.color = color; | |
| this.number = number; | |
| } | |
| private String color; | |
| private int number; | |
| public Ball(String color, int number) { | |
| this.color = color; | |
| this.number = number; | |
| } |
There was a problem hiding this comment.
It's better to provide already prepared String where is needed
| @Override | ||
| public String toString() { | ||
| return "Ball{" | ||
| + "color=" + color.name() |
There was a problem hiding this comment.
Suggested change
| + "color=" + color.name() | |
| + "color=" + color |
| import mate.academy.model.Color; | ||
|
|
||
| public class ColorSupplier { | ||
| public Color getRandomColor() { |
There was a problem hiding this comment.
Suggested change
| public Color getRandomColor() { | |
| public String getRandomColor() { |
|
|
||
| public class ColorSupplier { | ||
| public Color getRandomColor() { | ||
| int index = new Random().nextInt(Color.values().length); |
There was a problem hiding this comment.
Random should be class-level variable
| private static final int MAX_NUMBER = 100; | ||
|
|
||
| public Ball getRandomBall() { | ||
| Color color = new ColorSupplier().getRandomColor(); |
There was a problem hiding this comment.
ColorSupplier and Random shoud be class-level variables
| private static final int MAX_NUMBER = 100; | ||
|
|
||
| public Ball getRandomBall() { | ||
| Color color = new ColorSupplier().getRandomColor(); |
There was a problem hiding this comment.
Suggested change
| Color color = new ColorSupplier().getRandomColor(); | |
| String color = colorSupplier.getRandomColor(); |
Elena-Bruyako
suggested changes
Nov 3, 2024
Comment on lines
4
to
10
| private Color color; | ||
| private int number; | ||
|
|
||
| public Ball(Color color, int number) { | ||
| this.color = color; | ||
| this.number = number; | ||
| } |
Elena-Bruyako
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.