Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abnormal shutdown time when server is shut down #79

Open
cherrychip8293 opened this issue Nov 19, 2023 · 4 comments
Open

Abnormal shutdown time when server is shut down #79

cherrychip8293 opened this issue Nov 19, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@cherrychip8293
Copy link

I want you to know before reading this issue
I am uploading a report after continuously checking this issue for a month.

How to reproduce the bug

  1. Create logs to store as much as possible
  2. Then shut down the server

Bugs in this process can probably be reproduced only on an actual operating server.

This problem continues to cause systems to shut down improperly, causing backlash.

@matcracker
Copy link
Owner

Hi, first of all thanks for the report. The issue can be reproduced also on a empty server, just explode a lot of TNTs and then stop the server.

The problem is caused by this code:

It waits for the execution of all the queries before shutting down the server in order to prevent data loss. If I don't wait the queries, the latest logs will not be registered. I don't actually know how to fix it, unless I create an option that disables waiting for queries on shutdown. I don't think it's a good idea.

@matcracker matcracker added the enhancement New feature or request label Nov 22, 2023
@cherrychip8293
Copy link
Author

Hi, first of all thanks for the report. The issue can be reproduced also on a empty server, just explode a lot of TNTs and then stop the server.

The problem is caused by this code:

It waits for the execution of all the queries before shutting down the server in order to prevent data loss. If I don't wait the queries, the latest logs will not be registered. I don't actually know how to fix it, unless I create an option that disables waiting for queries on shutdown. I don't think it's a good idea.

It seems that this problem is not the only one involved. It seems that PMMP automatically forces a shutdown after a certain period of time.

@matcracker
Copy link
Owner

That's really strange. Are you sure is the plugin involved?

@cherrychip8293
Copy link
Author

진짜 이상하네요. 플러그인이 관련된 것이 확실합니까?

That's right, I checked everything for a week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants