Still cannot get Blackfriday

[rickb777]

There are several closed issues relating to this but it still seems to be a problem.

Firstly, I can do

$ go get -u github.com/matcornic/hermes/[email protected]
go: github.com/Masterminds/semver upgrade => v1.5.0
go: github.com/Masterminds/sprig upgrade => v2.22.0+incompatible
go: github.com/shurcooL/sanitized_anchor_name upgrade => v1.0.0
go: github.com/imdario/mergo upgrade => v0.3.10
go: github.com/olekukonko/tablewriter upgrade => v0.0.4
go: github.com/huandu/xstrings upgrade => v1.3.2
go: golang.org/x/crypto upgrade => v0.0.0-20200728195943-123391ffb6de
go: golang.org/x/net upgrade => v0.0.0-20200707034311-ab3426394381
go: github.com/google/uuid upgrade => v1.1.1
go: github.com/mattn/go-runewidth upgrade => v0.0.9
go: github.com/jaytaylor/html2text upgrade => v0.0.0-20200412013138-3577fbdbcff7
go: finding module for package github.com/mitchellh/copystructure
go: found github.com/mitchellh/copystructure in github.com/mitchellh/copystructure v1.0.0
go: github.com/mitchellh/reflectwalk upgrade => v1.0.1

So far, so good.

But then I run

$ go get -u ./...
go: finding module for package github.com/matcornic/hermes
go: found github.com/matcornic/hermes in github.com/matcornic/hermes v1.2.0
go: finding module for package gopkg.in/russross/blackfriday.v2
go: found gopkg.in/russross/blackfriday.v2 in gopkg.in/russross/blackfriday.v2 v2.0.1
go: r4/roster4/mail imports
	github.com/matcornic/hermes imports
	gopkg.in/russross/blackfriday.v2: gopkg.in/russross/[email protected]: parsing go.mod:
	module declares its path as: github.com/russross/blackfriday/v2
	        but was required as: gopkg.in/russross/blackfriday.v2

This is a failure I can't seem to recover from.

There seems to be a problem with Blackfriday which is messing with Hermes. Probably the Hemes dependency should be github.com/russross/blackfriday/v2 instead of gopkg.in/russross/blackfriday.v2
`.

[dpaks]

Could you suggest a workaround for this?

[rickb777]

I created a fork which works for me: PR #68

The important changes are:

• created a v2 code folder and moved the v2 code into it
• reverted the code not in v2 to be as per v1.2.x
• simplified v2/go.mod, which is the crucial change needed to fix this problem

If this PR is merged, v2 history will involve files in the v2 folder, whereas the toplevel files are only changed when making a v1 maintenance fix.

[mrinalwahal]

This problem requires an urgent solution. It caused breaking changes to my startup's live platform.

[Z-a-r-a-k-i]

Actually I think that you simply need to use
import "github.com/matcornic/hermes/v2" instead of import "github.com/matcornic/hermes

At least it did the trick for me and fixed the same error.