Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setDefaultEmailValues should maybe not set signature and greeting, #25

Open
thomasf opened this issue Nov 7, 2017 · 1 comment
Open

setDefaultEmailValues should maybe not set signature and greeting, #25

thomasf opened this issue Nov 7, 2017 · 1 comment
Assignees
@matcornic
Labels
enhancement

Comments

@thomasf
Copy link

thomasf commented Nov 7, 2017

Becuse sometimes they should not be set at all.
@matcornic
Copy link
Owner

Good point, it's because of zero values. I think I can come up with a solution that will set default values and let user override it at the same time.

@matcornic matcornic self-assigned this Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matcornic matcornic

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomasf @matcornic