This repository has been archived by the owner on Jun 26, 2018. It is now read-only.
DP-8645 remove nbsp from decorative links #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacchansky
suggested changes
Apr 19, 2018
There was a problem hiding this comment.
I think the non-breaking-space initially was required to avoid having the arrow icon become an orphan on narrower widths of decorative links. I'll attach a gif to explain what I mean more specifically, I'm not sure there's another way to do this without a non-breaking-space.
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the non-breaking space from the decorative links and uses css to space correctly
Related Issue / Ticket
Steps to Test
Screenshots
Additional Notes:
There are a large number of backstop files included, because removing the space and refactoring the css caused some links to break on different words.