Taking a look at the old PR to assert changes and see if they are salvageable or if I need to start from scratch

Versioning breakdown

Moved this back to Ready since I'm working on the higher priority bug

Resuming work. Gonna inspect #514 for ideas on the implementation of the update

🟢 [UPDATE]

While reviewing the PR changes were way too many and hard to follow since there's just a single commit for the whole set of changes.

Instead what I ended up doing is a more hands-on approach where I start applying the changes myself to the latest stage of the repo. Still tinkering a bit but leaving an update of what I'm doing to keep communication fluid 💪

Upgrading rainbowkit

Upgrading the @rainbow-me/rainbowkit dependency to its latest version throws the following warnings:

This is coherent with their package.json's peerDependencies object, where viem needs to be 2.x and wagmi ^2.9.0.

An unexpected peerDependency appeared with @celo/rainbowkit-celo. However, they seem to not have updated their code as well since their rainbowkit dependency is still set to 1.x. We need to dig deeper into this but will be dismissed since it's not the focus of this ticket

Resuming work by doing the update by myself using #514 as reference

Instead of troubleshooting in the dark fixing things like the one below

I'm gonna rely on Rainbowkit's migration guide

After running

yarn upgrade @rainbow-me/rainbowkit@2 wagmi@2 [email protected]

We got all the latest versions as shown on this message with a few minor version's offset:

By looking at viem's migration guide, it seems we have no breaking changes from its major version bump directly:

• https://viem.sh/docs/migration-guide.html#_2-x-x-breaking-changes

EDIT: However by looking at Simo's changes we might need to use some viem imports after all (link)

HOW TO DRILL DOWN THE CHANGES

The repo has the whole e2e flow by integrating stories that would act like the end user of the library (in our case, the SBT app).

So starting from the end user, how do changes affect the pipeline?

Stories

As on the SBT app, they import 2 key elements:

• MasaProvider. It consists of 2 providers:
  • MasaWalletProvider
  • MasaStateProvider
• Custom hooks that interact with the provider. What we care most in this scope are:
  • useWallet
  • useNetwork

MasaProvider

One important thing to mention is that MasaStateProvider makes use of TanStack/Query to manage the state and now it is a requirement for wagmi. Thus, since we cannot initiate 2 separated providers of TanStack/Query, we need to merge them.

The proposed solution on #514 was to just move it to:

• Move QueryProvider to the scope of MasaWalletProvider
• Create a wrapper provider for MasaWalletProvider that initiates:
  • WagmiProvider
  • QueryProvider
  • RainbowkitProvider
• Leave only Client management logic to MasaStateProvider (via MasaClientProvider)

Further detail of the changes will be given later 💪

Custom hooks

From a high-level perspective, it seems that only syntax changes are required and minor tweaks such as how internal functions/hooks are used and called. Will dive into that later as well

I'm a bit stuck with this task, gonna put it back to the ready column and take something else to get back to rhythm and come with a fresh mind to go at it again later 💪

Gonna do some pairing with @obasilakis here to move things forward 💪

Pushed the changes I'm most certain to be good, have some others stashed locally but at least have them pushed so its visible for everyone at:

• feat/MR-590/upgrate-rainbowkit-wagmi-viem

🟢 [UPDATE] Got story to work with new provider

NEXT STEPS

• Fix storybook server errors (mainly due to some key files not being updated)
• Filter networks through SupportedNetworks
• Add Masa Network support
• Test other functionalities

Code is available here: e1a5f22

🟢 [UPDATE] Splitting work with @obasilakis

Gonna split the work as such:

• @obasilakis is taking the syntax errors to be fixed
• @juanmanso is taking the masa mainnet and testnet addition to the chains array

Since this task no longer blocks masa-finance/masa-next-sbt#1444 due to the new findings and development cannot be finished in a couple of more hours, we dropped its priority and we moved it to the Ready column below the waterline

🟢 [EOD UPDATE]

Changes have been pushed to this branch:

• feat/MR-590/update-rainbowkit-wagmi-viem

Added Masa and MasaTestnet

Syntax errors

We are at 24 errors while running the storybook. Gonna continue fixing these next week 🚀