From 61e69ae7ec72d9d9da466563de5d2a1beed62311 Mon Sep 17 00:00:00 2001 From: marvin-j97 Date: Sun, 14 Jan 2024 18:04:23 +0100 Subject: [PATCH] add todo --- smoltable/src/table/mod.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/smoltable/src/table/mod.rs b/smoltable/src/table/mod.rs index acedbd3..58974b2 100644 --- a/smoltable/src/table/mod.rs +++ b/smoltable/src/table/mod.rs @@ -289,6 +289,8 @@ impl Smoltable { }) } */ + // TODO: count thrashes block cache + // TODO: unit test pub fn count(&self) -> fjall::Result<(usize, usize)> { use reader::Reader as TableReader; @@ -328,6 +330,8 @@ impl Smoltable { Ok((row_count, cell_count)) } + // TODO: GC thrashes block cache + // TODO: unit test pub fn run_version_gc(&self) -> fjall::Result { use reader::Reader as TableReader; @@ -429,6 +433,8 @@ impl Smoltable { Ok(deleted_cell_count) } + // TODO: delete row thrashes block cache + // TODO: allow deleting specific columns -> DeleteRowInput, also batch + limit it? pub fn delete_row(&self, row_key: String) -> fjall::Result { let mut count = 0;