Skip to content
This repository has been archived by the owner on Jul 16, 2020. It is now read-only.

Configurable extension #86

Open
tomeus opened this issue Jun 4, 2019 · 2 comments
Open

Configurable extension #86

tomeus opened this issue Jun 4, 2019 · 2 comments

Comments

@tomeus
Copy link

tomeus commented Jun 4, 2019

When choosing format as json it could be a fine generating file with json extension.

Maybe rename jsPath and jsFile to outputPath and outputFile, add outputExtension.

@martinlindhe
Copy link
Owner

I would welcome a patch if you find it needed, but just add outputExtension.

We want to avoid breaking existing configurations so I rather keep the jsPath and jsFile names for now, even they are a bit annoying in hindsight.

@tomeus
Copy link
Author

tomeus commented Mar 14, 2020

Hi. I have found the time and I return to this. I review the implementation again and say that this configuration parameter will only be taken for generateMultiple. Does it make sense to you? I'm also new in contributing, do you have any special pull request requests?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants