Feature: Start Marqo Docker with any flags #28
Conversation
| @@ -29,6 +29,10 @@ setenv = | |||
| TESTING_CONFIGURATION = LOCAL_MARQO_OS | |||
| PYTHONPATH = {toxinidir}{/}tests{:}{toxinidir} | |||
| PATH = {env:PATH}{:}{toxinidir}{/}scripts | |||
| ; this is set in case test needs to stop & rerun marqo. | |||
There was a problem hiding this comment.
These were set for each testenv since setting them in the parent [testenv] doesn't work for some reason.
There was a problem hiding this comment.
Doing some research it looks like each of these runs as its own subprocess, which would explain why exported env vars don't carry across
|
Can confirm these work when run on EC2 instances for the following environments:
For |
| @@ -29,6 +29,10 @@ setenv = | |||
| TESTING_CONFIGURATION = LOCAL_MARQO_OS | |||
| PYTHONPATH = {toxinidir}{/}tests{:}{toxinidir} | |||
| PATH = {env:PATH}{:}{toxinidir}{/}scripts | |||
| ; this is set in case test needs to stop & rerun marqo. | |||
There was a problem hiding this comment.
Doing some research it looks like each of these runs as its own subprocess, which would explain why exported env vars don't carry across
|
manually running and monitoring pipelines: |
|
all tests working as expected: everything passes except s2search_CI. This will be fixed with this issue: #30 |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature (for new kinds of tests)
What is the current behavior? (You can also link to an open issue here)
There is currently no simple way to restart marqo within application tests with different flags / env vars set.
What is the new behavior (if this is a feature change)?
rerun_marqo_with_env_varswas created so marqo can be stopped/restarted mid-test with new configuration (replicas, preloaded models, max ef const, etc)Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
When using this utility, note that the env vars must be formatted a certain way:
Ensure that:
-> single quotes cause some parsing issues and will affect the test outcome
End users will not interact with this, only developers / QA on marqo, so I think this is acceptable.