Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label tooltip #273

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Label tooltip #273

wants to merge 3 commits into from

Conversation

Busteren
Copy link
Contributor

@Busteren Busteren commented Jun 20, 2019 •
edited
Loading

Exposed onMouseOver, onMouseOut and onClick events to the config. This allows adding tooltip for label quite easily.

Might include an example of this once I got time or maybe modifying the existing Demo to showcase this?

Edit*
Closes #272

@Busteren
Added events to label
874af76 
onMouseOver, onMouseOut and onClick exposed in config to allow for tooltip on label text
@Busteren
Removed unused imports
1294b76
@Busteren Busteren mentioned this pull request Jun 20, 2019
Open
@Busteren
Copy link
Contributor Author

@jpetitcolas just thought to let you know about the PR with some additional features. I have done this on a few EventDrop charts and then when someone opened an issue I thought it would be handy to include it.

Also maybe update the NPM version. I guess the dependencies should maybe be bumped as well?

fzaninotto
fzaninotto reviewed Aug 27, 2019
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already an onMouseOver property on the drop set (see https://github.com/marmelab/EventDrops/blob/master/demo/demo.js#L37 for an example). What can your PR offer that the existing code doesn't allow to do?

CHANGELOG.md Outdated Show resolved Hide resolved
@Busteren
Copy link
Contributor Author

Reverted the changelog additions. The change from * to - was done by husky and not me.
This is for exposing mouse events on the label tooltip and not the drops themselves.
This is quite handy if one has very long label names, as they can be shortened and for example, show a tooltip on hover.

@fzaninotto
Copy link
Member

You want to show a tooltip when a user hovers on a tooltip? I'm not sure I understand. Could you be more specific about a possible use case?

@Busteren
Copy link
Contributor Author

Meant label and not label tooltip, this PR is in response to #272 so if you have a look at that you will see what the intuition behind it is.

It exposes the onMouseOver, onMouseOut and onClick events on the line-labels. Which is very handy if you have long line-label descriptions and say want to add a tooltip.

@JBBianchi JBBianchi mentioned this pull request Mar 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Left label identification by class or id
2 participants
@Busteren @fzaninotto