Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

异步日志判定 #95

Open
MZB2021 opened this issue Oct 4, 2023 · 1 comment
Open

异步日志判定 #95

MZB2021 opened this issue Oct 4, 2023 · 1 comment

Comments

@MZB2021
Copy link

MZB2021 commented Oct 4, 2023

在 log.cpp 中异步日志判定感觉不严谨。
截屏2023-10-04 16 23 46
这个判断如果 deque 满了就会直接将日志输出到 fp_ ,但是按着生产-消费者模型应该在push_back时阻塞,所以我认为应该把deque_->full()判断去掉。

@oo33shan
Copy link

oo33shan commented Oct 8, 2023

删掉会导致可能发生死锁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants