Node esm loader support #1728
Node esm loader support #1728
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1728 +/- ##
==========================================
- Coverage 90.31% 90.29% -0.03%
==========================================
Files 224 224
Lines 6828 6819 -9
==========================================
- Hits 6167 6157 -10
- Misses 661 662 +1 ☔ View full report in Codecov by Sentry. |
packages/compiler/loader.mjs
Outdated
| export function getFormat(url, context, defaultGetFormat) { | ||
| return extensionRegex.test(url) | ||
| ? format | ||
| : defaultGetFormat(url, context, defaultGetFormat); | ||
| } |
There was a problem hiding this comment.
Heads up that the loader hooks API has changed in LTS 16.12.0+ along with 17.x, which will presumably provide the initial API for 18.x. The change eliminates getFormat, moving its responsibility to the two remaining functions1:
resolve, as a hintload, which can use that hint but has the final say
You'll likely want to call this in resolve (assuming you need to support 14.x), with the fallback deferring to the result from defaultResolve.
Footnotes
-
besides
globalPreload, which is intended for setup not the dynamic runtime ↩
mlrawlings
force-pushed
the
node-esm-loader-support
branch
from
c5aab6f
to
8610afb
Compare
|
Marking as blocked because:
|
tigt
added
the
blocked
|
Note this will still probably happen because sometimes computers are terrible, but likely with a disclaimer about using it (and the |
Description
Resolves #1727
Adds support for loading Marko files directly as ESM via a node ESM Loader hook.
This means you can run node like
And importing Marko files will work as is.
Primarily this PR contains two main changes.
loader.mjsfile to the compiler package.importsadded when compiling a Marko template to have the filename (including extension) to be more native esm friendly.Checklist: