Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema::getField throws an error for unknown fields #264

Open
sebastian-lenz opened this issue Apr 19, 2019 · 1 comment
Open

Schema::getField throws an error for unknown fields #264

sebastian-lenz opened this issue Apr 19, 2019 · 1 comment

Comments

@sebastian-lenz
Copy link
Contributor

sebastian-lenz commented Apr 19, 2019 •
edited
Loading

As Schema::getField has an annotation of the return type, the code is not allowed to return false. I think we should remove the return type annotation to fix this issue.

craftql/src/Builders/Schema.php

Line 213 in d6d5343

return false;

@sebastian-lenz
Copy link
Contributor Author

See #265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sebastian-lenz