Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve design in any way #14

Open
audreyfeldroy opened this issue Aug 11, 2021 · 13 comments · Fixed by #80
Open

Improve design in any way #14

audreyfeldroy opened this issue Aug 11, 2021 · 13 comments · Fixed by #80
Assignees
Labels
enhancement New feature or request

Comments

@audreyfeldroy
Copy link
Member

This issue is a general invitation to anyone to submit pull requests that improve the design of the site in any way.

Tiny incremental improvements are best: find a design tweak that makes the site 1-5% better, and submit a PR for it. That will allow us to review your changes and merge them in quickly.

@audreyfeldroy audreyfeldroy added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 11, 2021
@suveshmoza
Copy link
Contributor

I would like to work on this issue.

@audreyfeldroy
Copy link
Member Author

Cool @suveshmoza. This one is yours.

Caution, there are other issues also touching design, specifically the one about multicolumn layout and the PR for form UX.

I suggest starting with the smallest design improvement you can think of which doesn't affect those 2 items. Perhaps something involving card styles would be a good one. Thoughts?

@suveshmoza
Copy link
Contributor

I will make sure of that and would be focusing on smaller improvements.

@suveshmoza
Copy link
Contributor

@audreyfeldroy made a PR #72 have a look

@tof-tof
Copy link
Contributor

tof-tof commented Aug 19, 2021

hi @audreyfeldroy, @suveshmoza I thought it would be cool to add a small lift to the buttons on hover to make the design more inituitive but I can't find where the css classed like btn and btn-primary are defined. What file can I find this in?

@audreyfeldroy
Copy link
Member Author

Hi @tof-tof, that sounds cool! You asked a great question.

So far we don't actually have a CSS file yet: the styles currently come from https://daisyui.com/.

Here is an example of a similar project showing how you can add styles in styles/global.css or similar, then import that file. You can try creating a similar css file and importing it. 🙂

@tof-tof
Copy link
Contributor

tof-tof commented Aug 19, 2021

thanks for this, very useful!

@GrungeKarma
Copy link
Contributor

I just submitted a visual change in #82. Let me know what you think. It was just a thought, but I like the way it affects the site.

@GrungeKarma
Copy link
Contributor

So there were some major card changes, lol. It is probably going to be easier to delete my pull request and start with the new card structure.

@audreyfeldroy
Copy link
Member Author

@GrungeKarma sounds good, and no rush on the focus rings, I know you've been contributing so much lately. Thanks again for PR #87 too. 🙏

Everyone, this issue is still open to other small, incremental design improvement PRs. All are welcome to submit PRs as proposals or create other design-related issues too.

@RaphaelGC7
Copy link

RaphaelGC7 commented Sep 3, 2021

@audreyfeldroy I would like to work in the footer of the page, this would help in SEO and improve navigation a little bit. May I ?

@audreyfeldroy
Copy link
Member Author

audreyfeldroy commented Sep 7, 2021

@RaphaelGC7 Hey, sorry I just saw your comment. I just merged in some really nice footer design work by @suveshmoza, and you're welcome to iterate on it in a PR with your ideas, if you'd like.

@ChrisBit ChrisBit mentioned this issue Oct 19, 2021
5 tasks
@namangirdhar16
Copy link

@audreyfeldroy i would like to work on the footer of the landing page.

@pydanny pydanny removed help wanted Extra attention is needed good first issue Good for newcomers labels Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants