Skip to content

Commit

Permalink
Bug 1615446 [wpt PR 21789] - Revert "Remove inDocument check for emit…
Browse files Browse the repository at this point in the history
…ting change events", a=testonly

Automatic update from web-platform-tests
Revert "Remove inDocument check for emitting change events"

This reverts commit 07d811aaeb0724d0d019b8d6bdba3d5de1dc9a5e.

The change this reverts fixed http://crbug.com/773680 which was intended
to fire change events for detached radio and checkbox input elements
when using input.dispatchEvent(new MouseEvent('click')), but also caused
input.click() to fire change events. Although these may seem to be the
same thing, firefox actually fires change events on input.dispatchEvent
but not input.click(). WebKit, and chrome before the patch this reverts
fire change events in neither of these cases.

I will file an html spec issue to address this compat issue. For now, it
seems important to stop firing these change events because it is getting
more attention than the lack of change events.

Bug: 773680, 1051482
Change-Id: Ia8217d34bf9a20c50ce008630e748a7dbda52c3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055590
Reviewed-by: Mason Freed <masonfreedchromium.org>
Commit-Queue: Joey Arhar <jarharchromium.org>
Cr-Commit-Position: refs/heads/master{#741251}

--

wpt-commits: 365db564379b12f979d4cd7139179c18d0bcc4fb
wpt-pr: 21789

UltraBlame original commit: 51364731d401f2df3dc7de1fba085d20e440488e
  • Loading branch information
marco-c committed Feb 19, 2020
1 parent 36cd6cd commit 9222fb8
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 308 deletions.

This file was deleted.

This file was deleted.

0 comments on commit 9222fb8

Please sign in to comment.