Chore: Update to typescript 5 (grafana#76511)

* Update dependency typescript to v5

* Update yarn.lock

* Fix typescript errors

* Update typescript version sdk

* Revert useDescription.ts

* Fix ts errors

* Fix Typescript errors after Symbol.unscopables type change

* Fix colormanipulator errors

* Update packages/grafana-data/src/vector/FunctionalVector.ts

* Fix ts errors in dashboardmigrator

* Fix sandbox component typescript error

* Update yarn

* Update to typescript 5.2

* Fix typescript error

* update typescript/vscode patch/sdk/whatever

* fix ts errors in elasticsearch

* Fix two errors in alerting

* Fix error in dashboard-scene

* Fix errors in dashboard tests

* Fix errors in explore tests

* Fix error in plugins sandbox

* fix error in DashboardQueryRunner

* fix errors in grafana-data

* fix errors in PanelChrome story

* update betterer

* better fix for cloud monitoring

* fix error in reducer tester

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Zoltán Bedi <[email protected]>
Co-authored-by: Josh Hunt <[email protected]>
Co-authored-by: joshhunt <[email protected]>

Author: 4 people

.betterer.results

@@ -4669,9 +4669,6 @@ exports[`better eslint`] = {
     "public/app/features/plugins/sandbox/distortion_map.ts:5381": [
       [0, 0, 0, "Do not use any type assertions.", "0"]
     ],
-    "public/app/features/plugins/sandbox/sandbox_components.tsx:5381": [
-      [0, 0, 0, "Unexpected any. Specify a different type.", "0"]
-    ],
     "public/app/features/plugins/sandbox/sandbox_plugin_loader.ts:5381": [
       [0, 0, 0, "Do not use any type assertions.", "0"],
       [0, 0, 0, "Do not use any type assertions.", "1"],
@@ -5542,12 +5539,11 @@ exports[`better eslint`] = {
     ],
     "public/app/plugins/datasource/cloud-monitoring/datasource.ts:5381": [
       [0, 0, 0, "Unexpected any. Specify a different type.", "0"],
-      [0, 0, 0, "Unexpected any. Specify a different type.", "1"],
-      [0, 0, 0, "Do not use any type assertions.", "2"],
+      [0, 0, 0, "Do not use any type assertions.", "1"],
+      [0, 0, 0, "Unexpected any. Specify a different type.", "2"],
       [0, 0, 0, "Unexpected any. Specify a different type.", "3"],
-      [0, 0, 0, "Unexpected any. Specify a different type.", "4"],
-      [0, 0, 0, "Do not use any type assertions.", "5"],
-      [0, 0, 0, "Do not use any type assertions.", "6"]
+      [0, 0, 0, "Do not use any type assertions.", "4"],
+      [0, 0, 0, "Do not use any type assertions.", "5"]
     ],
     "public/app/plugins/datasource/cloud-monitoring/functions.ts:5381": [
       [0, 0, 0, "Do not use any type assertions.", "0"],

.yarn/sdks/typescript/package.json

@@ -1,6 +1,6 @@
 {
   "name": "typescript",
-  "version": "4.8.4-sdk",
+  "version": "5.2.2-sdk",
   "main": "./lib/typescript.js",
   "type": "commonjs",
   "bin": {

.yarnrc.yml

@@ -7,7 +7,7 @@ enableTelemetry: false
 nodeLinker: pnp
 
 packageExtensions:
-  '@storybook/[email protected]':
+  "@storybook/[email protected]":
     dependencies:
       '@storybook/react-webpack5': 7.4.5
   [email protected]:
@@ -26,14 +26,14 @@ packageExtensions:
       react-simple-compat: 1.2.2
   [email protected]:
     peerDependencies:
-      prop-types: '*'
+      prop-types: "*"
   [email protected]:
     peerDependencies:
       react-dom: 17.0.1
 
 plugins:
   - path: .yarn/plugins/@yarnpkg/plugin-outdated.cjs
-    spec: 'https://mskelton.dev/yarn-outdated/v2'
+    spec: "https://mskelton.dev/yarn-outdated/v2"
 
 yarnPath: .yarn/releases/yarn-4.0.0.cjs
 # Uncomment the following lines if you want to use Verdaccio local npm registry. Read more at packages/README.md

package.json

@@ -226,7 +226,7 @@
     "tracelib": "1.0.1",
     "ts-jest": "29.1.1",
     "ts-node": "10.9.1",
-    "typescript": "4.8.4",
+    "typescript": "5.2.2",
     "webpack": "5.89.0",
     "webpack-bundle-analyzer": "4.9.0",
     "webpack-cli": "5.1.4",

packages/grafana-data/package.json

@@ -91,7 +91,7 @@
     "rollup-plugin-dts": "^5.0.0",
     "rollup-plugin-esbuild": "5.0.0",
     "rollup-plugin-node-externals": "^5.0.0",
-    "typescript": "4.8.4"
+    "typescript": "5.2.2"
   },
   "peerDependencies": {
     "react": "^17.0.0 || ^18.0.0",

packages/grafana-data/src/themes/colorManipulator.ts

@@ -32,9 +32,15 @@ export function hexToRgb(color: string) {
   color = color.slice(1);
 
   const re = new RegExp(`.{1,${color.length >= 6 ? 2 : 1}}`, 'g');
-  let colors = color.match(re);
+  let result = color.match(re);
 
-  if (colors && colors[0].length === 1) {
+  if (!result) {
+    return '';
+  }
+
+  let colors = Array.from(result);
+
+  if (colors[0].length === 1) {
     colors = colors.map((n) => n + n);
   }
 

packages/grafana-data/src/types/logs.ts

@@ -153,7 +153,7 @@ export interface DataSourceWithLogsContextSupport<TQuery extends DataQuery = Dat
 }
 
 export const hasLogsContextSupport = (datasource: unknown): datasource is DataSourceWithLogsContextSupport => {
-  if (!datasource) {
+  if (!datasource || typeof datasource !== 'object') {
     return false;
   }
 
@@ -253,7 +253,7 @@ export const hasSupplementaryQuerySupport = <TQuery extends DataQuery>(
 };
 
 export const hasLogsContextUiSupport = (datasource: unknown): datasource is DataSourceWithLogsContextSupport => {
-  if (!datasource) {
+  if (!datasource || typeof datasource !== 'object') {
     return false;
   }
 

packages/grafana-data/src/types/query.ts

@@ -66,9 +66,10 @@ export interface DataSourceWithQueryExportSupport<TQuery extends SchemaDataQuery
 export const hasQueryImportSupport = <TQuery extends SchemaDataQuery>(
   datasource: unknown
 ): datasource is DataSourceWithQueryImportSupport<TQuery> => {
-  if (!datasource) {
+  if (!datasource || typeof datasource !== 'object') {
     return false;
   }
+
   return 'importFromAbstractQueries' in datasource;
 };
 
@@ -78,7 +79,7 @@ export const hasQueryImportSupport = <TQuery extends SchemaDataQuery>(
 export const hasQueryExportSupport = <TQuery extends SchemaDataQuery>(
   datasource: unknown
 ): datasource is DataSourceWithQueryExportSupport<TQuery> => {
-  if (!datasource) {
+  if (!datasource || typeof datasource !== 'object') {
     return false;
   }
   return 'exportToAbstractQueries' in datasource;

packages/grafana-data/src/vector/FunctionalVector.ts

@@ -101,18 +101,8 @@ export abstract class FunctionalVector<T = any> implements Vector<T> {
   copyWithin(target: number, start: number, end?: number | undefined): this {
     throw new Error('Method not implemented.');
   }
-
-  [Symbol.unscopables](): {
-    copyWithin: boolean;
-    entries: boolean;
-    fill: boolean;
-    find: boolean;
-    findIndex: boolean;
-    keys: boolean;
-    values: boolean;
-  } {
-    throw new Error('Method not implemented.');
-  }
+  // Object not implemented
+  [Symbol.unscopables] = {};
 
   //--------------------------------------------------------------------------------
   // Delegated Array function -- these will not be efficient :grimmice:

packages/grafana-e2e-selectors/package.json

@@ -52,6 +52,6 @@
   "dependencies": {
     "@grafana/tsconfig": "^1.2.0-rc1",
     "tslib": "2.6.0",
-    "typescript": "4.8.4"
+    "typescript": "5.2.2"
   }
 }