-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: MappingSetDataFrame
: .to_csv()
and read_csv()
#517
Comments
I see the point, but its a bit of a lower priority. I would probably recommend a utility method
Rather than adding further IO logic into the MappingSetDataFrame class. |
That would be fine, but I'm not sure if I like it either. Another thing that a user needs to know to import. The logic for |
I would say we go with the pandas design, as it is familiar to other devs, i.e. pd.load_csv(..) |
Yes, I like that solution! |
MappingSetDataFrame
metadata
: path alternativeMappingSetDataFrame
: .to_csv()
and `read_csv()
MappingSetDataFrame
: .to_csv()
and `read_csv()MappingSetDataFrame
: .to_csv()
and read_csv()
I just changed the title and OP of this issue from being about allowing |
Overview
I was initially suggesting that we could have an alternative constructor for
MappingSetDataFrame
that could accept paths rather than objects, however, based on some more recent discussions (1, 2), it might be better to do design very similar topandas
:Reading
Or
read_tsv()
, or justread()
.It could accept various different combinations of params:
a. Path to a SSSOM TSV which includes a metadata comment.
b. Path to a SSSOM TSV with no metadata comment, and path to a metadata yaml.
c. Path to a SSSOM TSV with no metadata comment, and path to a metadata object.
d. a dataframe, and path to a metadata yaml.
e. a dataframe, and path to a metadata object.
Writing
Or
to_tsv()
.This would be an alternative or replacement to
parse_sssom_table()
.The text was updated successfully, but these errors were encountered: